Add to_samples and from_samples
#184
Merged
+39
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AbstractMCMC.jl documentation for PR #184 is available at: |
mhauru
approved these changes
Nov 5, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See TuringLang/DynamicPPL.jl#1087 (comment), this is the implementation of option (1) from that comment, as discussed in our developer meeting earlier.
I think it makes more sense to use
to_samplesandfrom_samplesinstead offrom_chainsandto_chains, it reads better.There are additional bits of AbstractChains interface in #180, but I don't want that to hold this up, because this functionality is semi-urgently needed in DynamicPPL.
Specifically, there is currently no easy way to obtain a Dict of parameters from
MCMCChains. Combined with the fact that you can now only reliably initialise parameters usingInitFromParams(::Dict), this means that there is no easy way to initialise sampling from one row ofMCMCChains.Chains.